This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Move Enzyme to devDependencies #1415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** see title **why make this change?:** This was mistakenly added to regular dependencies, when we only use it for testing. **test plan:** `rm -rf node_modules && yarn install && yarn build && yarn test` **issue:** None open yet, but thanks for @JLarky whose comment on facebookarchive#1385 (comment) prompted this.
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
Summary: **what is the change?:** see title **why make this change?:** This was mistakenly added to regular dependencies, when we only use it for testing. **test plan:** `rm -rf node_modules && yarn install && yarn build && yarn test` **issue:** None open yet, but thanks for JLarky whose comment on facebookarchive/draft-js#1385 (comment) prompted this. Closes facebookarchive/draft-js#1415 Differential Revision: D5961436 fbshipit-source-id: bb9c22bf9f29a7cfaea70d2b869b2fb17f31db8c
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **what is the change?:** see title **why make this change?:** This was mistakenly added to regular dependencies, when we only use it for testing. **test plan:** `rm -rf node_modules && yarn install && yarn build && yarn test` **issue:** None open yet, but thanks for JLarky whose comment on facebookarchive/draft-js#1385 (comment) prompted this. Closes facebookarchive/draft-js#1415 Differential Revision: D5961436 fbshipit-source-id: bb9c22bf9f29a7cfaea70d2b869b2fb17f31db8c
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **what is the change?:** see title **why make this change?:** This was mistakenly added to regular dependencies, when we only use it for testing. **test plan:** `rm -rf node_modules && yarn install && yarn build && yarn test` **issue:** None open yet, but thanks for JLarky whose comment on facebookarchive/draft-js#1385 (comment) prompted this. Closes facebookarchive/draft-js#1415 Differential Revision: D5961436 fbshipit-source-id: bb9c22bf9f29a7cfaea70d2b869b2fb17f31db8c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
see title
why make this change?:
This was mistakenly added to regular dependencies, when we only use it
for testing.
test plan:
rm -rf node_modules && yarn install && yarn build && yarn testissue:
None open yet, but thanks for @JLarky whose comment on
#1385 (comment)
prompted this.