Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Commit

Permalink
aria-haspop indicates popup menus. It is not needed here
Browse files Browse the repository at this point in the history
Summary: `aria-haspopup` is used to indicate "popup button"; buttons that, when pressed, show a little menu of options. It's not meant to indicate any element that has a dialog associated with it. In the case of draft.js, the `aria-expanded` attribute is used to indicate that the input has a dropdown with options.

Reviewed By: spicyj

Differential Revision: D5550366

fbshipit-source-id: 90249146a7f69f538ab2177842ee925825238ccb
  • Loading branch information
jessebeach authored and facebook-github-bot committed Aug 3, 2017
1 parent 7f0cab2 commit 744e9b4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions src/component/base/DraftEditor.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,6 @@ class DraftEditor extends React.Component {
const ariaExpanded = ariaRole === 'combobox'
? !!this.props.ariaExpanded
: null;
const ariaHasPopup = ariaRole === 'combobox'
? !!this.props.ariaHasPopup
: null;

return (
<div className={rootClass}>
Expand All @@ -254,7 +251,6 @@ class DraftEditor extends React.Component {
this._showPlaceholder() ? this._placeholderAccessibilityID : null
}
aria-expanded={readOnly ? null : ariaExpanded}
aria-haspopup={readOnly ? null : ariaHasPopup}
aria-label={this.props.ariaLabel}
aria-multiline={this.props.ariaMultiline}
autoCapitalize={this.props.autoCapitalize}
Expand Down
1 change: 0 additions & 1 deletion src/component/base/DraftEditorProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export type DraftEditorProps = {
ariaControls?: string,
ariaDescribedBy?: string,
ariaExpanded?: boolean,
ariaHasPopup?: boolean,
ariaLabel?: string,
ariaMultiline?: boolean,

Expand Down

0 comments on commit 744e9b4

Please sign in to comment.