Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-translations): add Japanese translation for "warning" #9362

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix(theme-translations): add Japanese translation for "warning" #9362

merged 1 commit into from
Oct 5, 2023

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Oct 1, 2023 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The new admonition label "warning" hasn't been translated to Japanese yet.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#9308

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 1, 2023
@netlify
Copy link

netlify bot commented Oct 1, 2023 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3dc94f8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6519630bb676da00085b1545
😎 Deploy Preview https://deploy-preview-9362--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 88 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 80 🟢 98 🟢 92 🟢 100 🟠 89 Report

@tats-u
Copy link
Contributor Author

tats-u commented Oct 1, 2023

Rebased to the last commit where the CI succeeded.

@tats-u tats-u changed the title Add Japanese translation for "warning" fix(theme-translations): add Japanese translation for "warning" Oct 1, 2023
Josh-Cena
Josh-Cena approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 5, 2023
@slorber
Copy link
Collaborator

slorber commented Oct 5, 2023

Thanks 👍

@slorber slorber merged commit bca3752 into facebook:main Oct 5, 2023
19 of 30 checks passed
@tats-u tats-u deleted the admonition-warning-jp branch October 5, 2023 08:44
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tats-u @slorber @Josh-Cena @facebook-github-bot