Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): use MDX comments instead of HTML comments #8516

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jan 6, 2023

Upfront work useful for the MDX 2 migration (#8288)

HTML comments are not supported anymore in MDX 2

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jan 6, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 6, 2023
@netlify
Copy link

netlify bot commented Jan 6, 2023

[V2]

Name Link
🔨 Latest commit 1d756f0
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63b83b26a59500000982a902
😎 Deploy Preview https://deploy-preview-8516--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 95 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 82 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber merged commit 9c9d17d into main Jan 6, 2023
@slorber slorber deleted the slorber/migrate-mdx-comments branch January 6, 2023 15:22
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Size Change: +26 B (0%)

Total Size: 890 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 71 kB 0 B
website/build/assets/css/styles.********.css 112 kB 0 B
website/build/assets/js/main.********.js 666 kB +26 B (0%)
website/build/index.html 40.9 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants