-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): simplify plugin API, support route.props (experimental) #10042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: -6.8 kB (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
…into slorber/refactor-contentLoaded
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 28, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXPERIMENTAL
This feature is considered experimental for now.
It is preferable that third-party plugin authors wait for it to become stable/documented before relying on it.
Motivation
The plugin API is currently needlessly complicated and confusing.
Even the most basic example involves too much ceremony:
https://docusaurus.io/docs/api/plugin-methods/lifecycle-apis
We want to make this simpler, the user shouldn't need to think about filesystem paths and created modules, but just "declare" that the component/route should receive.
This new
route.props
API can already greatly simplify our own plugins.Note: the
route.modules
API will remain useful when a module need to be shared between multiple routes. However, we'll later also refactor it to not use the confusingcreateData()
API.We'll progressively migrate all
contentLoaded
APIs toward a more declarative model, and eventually make it synchronous to ensure it does not perform any IO operation. This will further permit us to optimize the DX. We can bail out of useless computations if we have everything in memory instead of having to query the filesystem.Test Plan
unit tests + dogfood on our own plugins
Test links
https://deploy-preview-10042--docusaurus-2.netlify.app/