Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docusaurus-translations & docusaurus-version not working #851

Closed
endiliey opened this issue Jul 14, 2018 · 0 comments
Closed

docusaurus-translations & docusaurus-version not working #851

endiliey opened this issue Jul 14, 2018 · 0 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@endiliey
Copy link
Contributor

endiliey commented Jul 14, 2018 •
edited
Loading

🐛 Bug Report

There is a bug in our write-translations file, it couldn't understand ES6.
Note that this bug only occurs when we run write-translations when docusaurus is installed as a npm package

Related code:
https://github.com/facebook/Docusaurus/blob/master/lib/write-translations.js

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

git clone https://github.com/endiliey/endiliey.github.io
cd endiliey.github.io/website
yarn && yarn write-translations

Expected behavior

Generating translations file work correctly

Actual Behavior

Error because it couldn't understand ES6
error

Travis CI error
travis

Observation

This bug occurs because babel-register ignores node_modules by default. We should allow babel transpiling for Docusaurus project installed in node_modules

Reproducible Demo

https://github.com/endiliey/endiliey.github.io

Update:
yarn version also not working

yarn run version 1.0.0

image
@endiliey endiliey added bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. labels Jul 14, 2018
@endiliey endiliey changed the title Write-translations is not working docusaurus-translations & docusaurus-version not working Jul 14, 2018
@endiliey endiliey mentioned this issue Jul 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@endiliey