Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky sidebars don’t stick in desktop safari #1597

Closed
brainkim opened this issue Jun 10, 2019 · 7 comments
Closed

Sticky sidebars don’t stick in desktop safari #1597

brainkim opened this issue Jun 10, 2019 · 7 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. status: claimed Issue has been claimed by a contributor who plans to work on it.

Comments

@brainkim
Copy link

brainkim commented Jun 10, 2019

🐛 Bug Report

Screen Shot 2019-06-10 at 6 06 44 PM

The sidebars on the docs pages don’t stick in desktop safari (Safari Version 12.1, MacOS Version 10.14.4 Mojave).

Have you read the Contributing Guidelines on issues?

yis

To Reproduce

  1. Open https://channel.js.org/docs/quickstart in safari
  2. Scroll down

Expected behavior

Sidebas exhibit the same scroll behavior they do in Chrome

(Write what you thought would happen.)

Actual Behavior

They don’t

(Write what happened. Add screenshots, if applicable.)

Reproducible Demo

no thanks!

@brainkim
Copy link
Author

May be related to #1241

@brainkim
Copy link
Author

Duplicate of #877

@yangshun yangshun reopened this Jun 10, 2019
@yangshun
Copy link
Contributor

Thanks @brainkim, this is a legit issue I discovered as well. The issues you've linked earlier are v1 issues hence they're not duplicates. The reason is because we're not including autoprefixer in the CSS webpack config and safari needs -webkit-sticky instead of just sticky.

@yangshun yangshun added 2.x bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. labels Jun 10, 2019
@shakcho
Copy link
Contributor

shakcho commented Jun 13, 2019

@yangshun I would like to work on it, I just want to know do I need to autoprefixer or just need to update the css.

@yangshun
Copy link
Contributor

@shakcho it's yours! Let's do autoprefixer as it's the more futureproof way. Please look at Create React App and we can emulate their webpack config for autoprefixing.

@yangshun yangshun added the status: claimed Issue has been claimed by a contributor who plans to work on it. label Jun 13, 2019
@shakcho
Copy link
Contributor

shakcho commented Jun 13, 2019

@yangshun I also thinking the same. I will raise Pull Request ASAP.

@endiliey
Copy link
Contributor

#1605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. status: claimed Issue has been claimed by a contributor who plans to work on it.
Projects
None yet
Development

No branches or pull requests

4 participants