-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sticky sidebars don’t stick in desktop safari #1597
Comments
May be related to #1241 |
Duplicate of #877 |
Thanks @brainkim, this is a legit issue I discovered as well. The issues you've linked earlier are v1 issues hence they're not duplicates. The reason is because we're not including autoprefixer in the CSS webpack config and safari needs |
@yangshun I would like to work on it, I just want to know do I need to autoprefixer or just need to update the css. |
@shakcho it's yours! Let's do autoprefixer as it's the more futureproof way. Please look at Create React App and we can emulate their webpack config for autoprefixing. |
@yangshun I also thinking the same. I will raise Pull Request ASAP. |
🐛 Bug Report
The sidebars on the docs pages don’t stick in desktop safari (Safari Version 12.1, MacOS Version 10.14.4 Mojave).
Have you read the Contributing Guidelines on issues?
yis
To Reproduce
Expected behavior
Sidebas exhibit the same scroll behavior they do in Chrome
(Write what you thought would happen.)
Actual Behavior
They don’t
(Write what happened. Add screenshots, if applicable.)
Reproducible Demo
no thanks!
The text was updated successfully, but these errors were encountered: