Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No branded docusaurus-init #1196

Closed
JoelMarcey opened this issue Jan 23, 2019 · 11 comments
Closed

No branded docusaurus-init #1196

JoelMarcey opened this issue Jan 23, 2019 · 11 comments
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@JoelMarcey
Copy link
Contributor

🚀 Feature

A no-branded, totally vanilla docusaurus-init

Have you read the Contributing Guidelines on issues?

Yes

Motivation

via @jordwalke

Pitch

Have a version of docusaurus-init that does not include any logos, images, etc. Just vanilla.

Could be run like docusaurus-init --no-brand or something.

@JoelMarcey JoelMarcey added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. hackathon labels Jan 23, 2019
@kyldvs
Copy link

kyldvs commented Jan 28, 2019

I just ran into this too, was hard to make sure I found and removed all the branding. I think I still use a css class prefixed with fb in the footer I couldn't find to rename.

@ahmadalfy
Copy link
Contributor

Can someone clarify what's the hackathon tag? should contributors avoid doing efforts on it?

@JoelMarcey
Copy link
Contributor Author

@ahmadalfy Hi - please feel free to do work on those with the hackathon tag. Actually, let me remove it now. It was for a quick hackathon last week.

@ahtee
Copy link
Contributor

ahtee commented Feb 23, 2019

@kyldvs mentioned that it took a while to remove all branding, and this is a no-branding discussion, but what if there was a central place where you could change the branding everwhere if you did have a brand? and if that field is empty or null then it removes all branding from the template..?

@endiliey endiliey added good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. labels Jul 18, 2019
@alexieyizhe
Copy link

@endiliey is anyone working on this? if not, I'd love to give it a shot 👍

@endiliey
Copy link
Contributor

endiliey commented Oct 8, 2019 via email

@fanny
Copy link
Contributor

fanny commented Apr 4, 2020

@yangshun I think that would be a good way to explore more the plugins config. What do you think?

@leeyspaul
Copy link

Reviving an old thread. What constitutes vanilla? I was browsing around and starting with init gave me a few reference to docusarus but not a lot. Thank you for the context in advance. :]

@JoelMarcey

@slorber
Copy link
Collaborator

slorber commented Oct 8, 2020

Not sure exactly either what should be done, but it looks related to #3489

@leeyspaul
Copy link

Yeah, it seems like #3489 is about splitting up the base template into a series of templates for different use cases. So this vanilla template would be the base perhaps.

I think the maintenance factor is a valid concern too. Definitely still seems like an open and ongoing discussion. @fanny might have some creative ideas!

@slorber
Copy link
Collaborator

slorber commented Jun 10, 2021

I'm considering that this issue is v1

v2 now has a classic template with no Facebook branding, and has a separate template for Facebook projects.

Considering the classic template as the "vanilla" template, but I'm not 100% sure to understand what vanilla means exactly here. v2 users don't complain much about having to remote existing branding.


The Docusaurus team is actively working on Docusaurus v2.

After a very long alpha, Docusaurus v2 is now in beta.
We believe that the v2 beta is already better than v1, and v2 is ready for maintstream adoption.

Apart from critical issues and security fixes, we don't plan to invest much time on Docusaurus v1 anymore.

We are all closing v1 issues.
Maybe the current issue is already fixed in Docusaurus v2.
Please try to upgrade, and if the issue is still there on Docusaurus v2, open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Development

No branches or pull requests

10 participants