Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix react-refresh babel plugin not applied #8952

Merged
merged 1 commit into from
May 4, 2020
Merged

fix react-refresh babel plugin not applied #8952

merged 1 commit into from
May 4, 2020

Conversation

tanhauhau
Copy link
Contributor

@charrondev @ianschmitz

The react-refresh/babel plugin got added as the option of babel-plugin-named-asset-import 🙈😂

charrondev
charrondev approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@charrondev charrondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I'm guessing this is the result of a resolved merge conflict.

@ianschmitz ianschmitz added this to the 4.0 milestone May 4, 2020
@ianschmitz
Copy link
Contributor

Interesting that it still works this way!

@ianschmitz ianschmitz merged commit 62e8e3d into facebook:master May 4, 2020
@ianschmitz
Copy link
Contributor

Thanks @tanhauhau!

@tanhauhau tanhauhau deleted the tanhauhau/fix-react-refresh-plugin branch May 4, 2020 23:23
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charrondev charrondev charrondev approved these changes

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tanhauhau @ianschmitz @charrondev @facebook-github-bot