Do not check for interactive session to shut down dev server

[jeremywadsack]

Fixes #8688

As discussed in #8868, Docker sessions shut down the dev server before it gets a chance to use it because Docker appears to be "interactive" and then closes stdin immediately. The workarounds were to set CI=true (which worked in some cases but not others) or to configure the Docker container to maintain an open TTY.

This shouldn't be necessary and is affecting both CI deployments and other environments.

The problem is a change in #7203, which intended to close the development server when stdin closed because otherwise it was left hanging open. That now is closing prematurely in cases where it's used in Docker.

During development of #7203, the check for an interactive session was added to fix it crashing in CRA's CI. However that didn't resolve the issue for some uses of Phoenix development watcher, which was fixed by checking that the CI environment variable is not set. The latter check should resolve the issue for CRA CI by itself — most CI systems set that variable.

While I couldn't figure out how to test a branch as an installed module (because of the monorepo nature), I did test this by hacking my Circle CI configuration to apply the patch and verified that resolved the CI issue for me:

sed -i '/process.env.CI/ s/isInteractive [|]*//' node_modules/react-scripts/scripts/start.js

I'm opening this PR in the hopes that it runs the CRA CI and will verify if this does not introduce a CI crash.

[facebook-github-bot]

Hi @jeremywadsack!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[endophage]

LGTM!

Not a maintainer but straight-foward default behaviour with a simple config toggle is better than some magic auto-detection any day.

[luispabon]

Is there any chance this fix can be released as 3.4.2? Looks like a regression in 3.4.1

[pluma]

This has been merged for over a week and fixes a regression from 3.4.0 to 3.4.1. I don't want to sound impatient but could we please get a hotfix?