From 0e817d275ae872e0ca38da8f00c06f0419fffc56 Mon Sep 17 00:00:00 2001 From: Luis Nell Date: Fri, 23 Mar 2018 13:00:26 +0100 Subject: [PATCH 1/4] Removes Chokidar Recursive Flag According to the changelog it is not necessary anymore as it doesn't do anything. --- packages/react-scripts/template/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 21cf719e961..6dbe25096b3 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -621,7 +621,7 @@ Then in `package.json`, add the following lines to `scripts`: ```diff "scripts": { + "build-css": "node-sass-chokidar src/ -o src/", -+ "watch-css": "npm run build-css && node-sass-chokidar src/ -o src/ --watch --recursive", ++ "watch-css": "npm run build-css && node-sass-chokidar src/ -o src/ --watch", "start": "react-scripts start", "build": "react-scripts build", "test": "react-scripts test --env=jsdom", From 6a38ae2e4db24ea235ac761c423e5680d9084f90 Mon Sep 17 00:00:00 2001 From: Luis Nell Date: Fri, 23 Mar 2018 13:02:02 +0100 Subject: [PATCH 2/4] Removes initial build on SCSS watch Chokidar now does this on it's own. --- packages/react-scripts/template/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 6dbe25096b3..233016b97c5 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -637,7 +637,7 @@ To enable importing files without using relative paths, you can add the `--incl ``` "build-css": "node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/", -"watch-css": "npm run build-css && node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/ --watch --recursive", +"watch-css": "node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/ --watch --recursive", ``` This will allow you to do imports like From 3b8947994256bf43ce16e491d5c5ed4cd8702db7 Mon Sep 17 00:00:00 2001 From: Luis Nell Date: Tue, 27 Mar 2018 08:55:40 +0200 Subject: [PATCH 3/4] Removes sass watch recursive, default include-path as proposed by @michaelwayman --- packages/react-scripts/template/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 233016b97c5..518ce8aa036 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -636,8 +636,8 @@ To share variables between Sass files, you can use Sass imports. For example, `s To enable importing files without using relative paths, you can add the `--include-path` option to the command in `package.json`. ``` -"build-css": "node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/", -"watch-css": "node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/ --watch --recursive", +"build-css": "node-sass-chokidar --include-path ./node_modules src/ -o src/", +"watch-css": "node-sass-chokidar --include-path ./node_modules src/ -o src/ --watch", ``` This will allow you to do imports like From 7aae09ce90627b847c492895ffeafaec68deffbd Mon Sep 17 00:00:00 2001 From: Luis Nell Date: Tue, 27 Mar 2018 08:57:52 +0200 Subject: [PATCH 4/4] Removes another left-over build-css --- packages/react-scripts/template/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 518ce8aa036..2c8ec3eda5e 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -621,7 +621,7 @@ Then in `package.json`, add the following lines to `scripts`: ```diff "scripts": { + "build-css": "node-sass-chokidar src/ -o src/", -+ "watch-css": "npm run build-css && node-sass-chokidar src/ -o src/ --watch", ++ "watch-css": "node-sass-chokidar src/ -o src/ --watch", "start": "react-scripts start", "build": "react-scripts build", "test": "react-scripts test --env=jsdom",