Added a note with instructions on eslint plugin configuration #348
Conversation
Since the only editor that I found the issue was Atom, I added just the instruction for the linter-eslint plugin.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
| You would need to install an ESLint plugin for your editor first. | ||
| You would need to install an ESLint plugin for your editor first. | ||
|
|
||
| >Note: if you are using the `linter-eslint` plugin on Atom, make sure that **Use global ESLint installation** option is checked. |
There was a problem hiding this comment.
Let’s make this a regular paragraph, it’s too easy to skip now.
There was a problem hiding this comment.
Better yet,
A note for Atom
linter-eslintusersIf you use, ...
(screenshot)
There was a problem hiding this comment.
So, create that as note with that format or a regular paragraph?
Where should I add the screenshot?
There was a problem hiding this comment.
Let’s add a note with that format, it will be visible thanks to the screenshot.
Screenshot should be inline in the note.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
|
Thanks! |
|
Thank you for being part of my very first pull request! 😄 |
* Added a note with instructions on eslint plugin configuration Since the only editor that I found the issue was Atom, I added just the instruction for the linter-eslint plugin. * Change the format of the instructions and add screenshot.
I've installed both Sublime Text and Visual Studio Code in order to see if I needed to add any extra configuration to make eslint work.
Since the only editor that I found the issue was Atom, I added
just the instruction for the linter-eslint plugin.
Below is the instruction that I added: