Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-scripts version 4.0.0-next.96 extends eslint rules by default #9759

Closed
andrei9669 opened this issue Oct 6, 2020 · 2 comments
Closed

Comments

@andrei9669
Copy link

Describe the bug

Starting from version 4.0.0-next.96 my custom eslint rules are extended automatically into my react app. It works fine on version 4.0.0-next.77.

Did you try recovering your dependencies?

npm version 6.14.8

Which terms did you search for in User Guide?

  • Advanced Configuration
  • EXTEND_ESLINT

Environment

current version of create-react-app: 3.4.1
running from /home/andreisirotin/.npm/_npx/38194/lib/node_modules/create-react-app

System:
OS: Linux 5.4 Ubuntu 20.04.1 LTS (Focal Fossa)
CPU: (8) x64 Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
Binaries:
Node: 10.19.0 - /usr/bin/node
Yarn: 1.22.5 - /usr/bin/yarn
npm: 6.14.8 - ~/Documents/3admin/admin-panel/node_modules/.bin/npm
Browsers:
Chrome: 85.0.4183.83
Firefox: 81.0
npmPackages:
react: ^16.13.1 => 16.13.1
react-dom: ^16.13.1 => 16.13.1
react-scripts: 4.0.0-next.77 => 4.0.0-next.77
npmGlobalPackages:
create-react-app: Not Found

Steps to reproduce

  1. npx create-react-app project
  2. cd project
  3. npm i [email protected]
  4. npx eslint --init
✔ How would you like to use ESLint? · style
✔ What type of modules does your project use? · esm
✔ Which framework does your project use? · react
✔ Does your project use TypeScript? · No / Yes
✔ Where does your code run? · browser
✔ How would you like to define a style for your project? · guide
✔ Which style guide do you want to follow? · airbnb
✔ What format do you want your config file to be in? · JavaScript
  1. npm run start

Expected behavior

I expected it to work like it used to

Actual behavior

It works as if I have EXTEND_ESLINT=true in my .env file, which doesn't allow it to run cus I have some half finished code.

Reproducible demo

https://github.com/andrei9669/react_scripts_next

@andrei9669
Copy link
Author

probably related to #9683 but not quite sure

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant