Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing peer dependency in react-scripts #8022

Closed
Andarist opened this issue Nov 24, 2019 · 3 comments · Fixed by #8038
Closed

Missing peer dependency in react-scripts #8022

Andarist opened this issue Nov 24, 2019 · 3 comments · Fixed by #8038

Comments

@Andarist
Copy link
Contributor

You have peerDependenciesMeta there without actual peerDependencies - I believe this doesn't work as expected, peerDependenciesMeta requires peerDependencies to be there as it's merely additional information, not a replacement.

@ianschmitz
Copy link
Contributor

ianschmitz commented Nov 24, 2019

Hmm it would seem you're correct: https://github.com/yarnpkg/yarn/pull/6671/files.

Adding under peerDependencies will start throwing warnings for folks that don't have [email protected] or later.

We may want to do this as part of our v4 release. I'll mark as such and see what the other maintainers think.

@ianschmitz ianschmitz added this to the 4.0 milestone Nov 24, 2019
@Andarist
Copy link
Contributor Author

From what I understand CRA+TS would be broken for strict package managers like pnpm or yarn in pnp mode without this peer dependency specified. I was facing similar problem lately for the other package and we decided to just go with specifying peer dep and marking it as optional. We can always recommend using new version of npm and on older versions it will merely cause a warning - things will still be very much functional, so... 🤷‍♂

@ianschmitz
Copy link
Contributor

ianschmitz commented Nov 24, 2019

Good point. Oct 21 appears to have been the first Node release that included npm >= 6.11. I'm okay with the warning to support the other package managers.

@ianschmitz ianschmitz modified the milestones: 4.0, 3.4 Nov 24, 2019
@ianschmitz ianschmitz modified the milestones: 3.4, 3.3 Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants