-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing peer dependency in react-scripts #8022
Comments
Hmm it would seem you're correct: https://github.com/yarnpkg/yarn/pull/6671/files. Adding under We may want to do this as part of our v4 release. I'll mark as such and see what the other maintainers think. |
From what I understand CRA+TS would be broken for strict package managers like pnpm or yarn in pnp mode without this peer dependency specified. I was facing similar problem lately for the other package and we decided to just go with specifying peer dep and marking it as optional. We can always recommend using new version of npm and on older versions it will merely cause a warning - things will still be very much functional, so... 🤷♂ |
Good point. Oct 21 appears to have been the first Node release that included npm >= 6.11. I'm okay with the warning to support the other package managers. |
You have
peerDependenciesMeta
there without actualpeerDependencies
- I believe this doesn't work as expected,peerDependenciesMeta
requirespeerDependencies
to be there as it's merely additional information, not a replacement.The text was updated successfully, but these errors were encountered: