-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Advanced config: HOST description misleading #7671
Labels
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Can someone triage this? |
Sounds reasonable. Want to send a PR updating the docs? |
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the advanced configuration page, the description for the
HOST
var isHowever, that's not quite correct, as it seems to bind to
0.0.0.0
(all available hostnames on the network interface). This can be seen from the console message when runningnpm run start
:This is useful for accessing the development device from other devices on the network, but is undesirable when the developer expects to only be able to access the content via
localhost
.I'm not objecting to the default behavior, but I think that the docs should be updated to reflect what's actually happening. For example, setting
in
.env
produces the actual behavior in the current description.I suggest changing to the description to something like:
The text was updated successfully, but these errors were encountered: