-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix end-to-end test to use packages from master #698
Comments
It's weird that it only fails in Node v4.5.0, not in 6. We already run I also tried running locally on a fresh Node v4.5.0 installation and |
I see what the problem is now, we run I think the release script possibly needs to be changed too, because it uses the same strategy when it bundles the dependencies. Unless we publish all the other packages first, the script will bundle the eslint-config-react-app from npm. Perhaps we could make this easier by publishing everything with |
The e2e test should be fixed here: #699. |
Thanks! |
As noted in #696 (comment), we should have end-to-end test use the versions of packages from the repo instead of ones from npm. We might need to run
lerna bootstrap
in it or something.The text was updated successfully, but these errors were encountered: