Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable react/no-deprecated rule after its been adjusted #5204

Open
Timer opened this issue Oct 1, 2018 · 3 comments
Open

Re-enable react/no-deprecated rule after its been adjusted #5204

Timer opened this issue Oct 1, 2018 · 3 comments
Labels
tag: underlying tools
Milestone
5.x

Comments

@Timer
Copy link
Contributor

Timer commented Oct 1, 2018

Right now react/no-deprecated warns multiple times over on deprecated lifecycle methods.

This behavior isn't very optimal -- we should file an issue with ESLint and ask them to remove it once a formal warning is added to React.
@Timer Timer added this to the 2.x milestone Oct 1, 2018
@Timer Timer mentioned this issue Oct 1, 2018
Merged
@gaearon
Copy link
Contributor

gaearon commented Oct 1, 2018

To be more precise, I don't think eslint-plugin-react would remove it (and the rule itself is useful) but I'd prefer to activate after React itself starts considering them deprecated (and the users have run the codemod).

@Timer
Copy link
Contributor Author

Timer commented Oct 1, 2018

Sure, that makes sense.

@Timer Timer modified the milestones: 2.x, 2.0.x Oct 1, 2018
@iansu iansu modified the milestones: 2.1.x, 3.x Mar 10, 2019
@abhinavsingi
Copy link

@gaearon @Timer Should this be enabled now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag: underlying tools
Projects
None yet
Milestone
5.x
Development

No branches or pull requests
4 participants
@iansu @Timer @gaearon @abhinavsingi