-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent png breaks loaders #396
Comments
Is your image file inside |
Ah, I see! Makes sense. Is there a way to opt-out so to speak, for a particular line or file? I guess having the css file separate and including it in the html would be one way. I'm integrating the app created from this tool into an existing vanilla js page. This can be closed. |
We are thinking about ways to reference images elsewhere (outside of Webpack). But this would mean you'd have to think about content hashes yourself: currently Webpack does it for you. Can you explain more about why you don't want to put the image next to the CSS using it? |
In this particular instance the site is already including the image in regular html fashion, so I wanted to link to that, which was outside of the react app. In this instance the react app was being embedded in an existing html page with it's own shenanigans going on. It's probably not the correct use case for this project but I'm making it work :). I solved this by just using the data url inline in the css instead of linking to the image. It does mean there is technically duplication but it's only a small image so I'm not too worried. |
I guess 'solved' is the wrong word, more a workaround. But I think it's because of my non-standard use case. |
Yeah, let’s close for now. Maybe if more such use cases come up we can figure out a better common solution. Thanks. |
I get an error when loading a png file with transparency. I tried in the javascript and in the css, same result for both. When I load it in the browser though the image loads and works anyway.
The text was updated successfully, but these errors were encountered: