-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build errors are not printed to console due to broken require #2936
Comments
Also worth looking into why this didn't fail CI. |
Hi @svicalifornia; I'd love a bit more information -- are you ejected? |
Also, what version of Really, this shouldn't bomb out with npm >= 3 as it does dependency flattening and |
Fix up in #2938. |
Released in |
@Timer My colleague and I experienced the issue on systems running npm 4.2 and 5.1.0. Thanks for the quick fix! |
Are you ejected? |
We are not ejected, but we are using react-app-rewired to add loaders and plugins to our webpack config. |
Hmm interesting. Non determinism at its finest haha. |
Is this a bug report?
Yes
Can you also reproduce the problem with npm 4.x?
Yes.
The Problem
Build errors do not print to console to due to an fatal error introduced in PR #2650.
PR #2650 added a new file printBuildError.js, which requires
lodash/get
. However, lodash is not listed as a dependency in react-script's package.json, so any execution path that requires printBuildError.js will fail to require 'lodash/get', causing node to throw a fatal exception.Proposed Resolution
'lodash' or 'lodash.get' should be added to package.json, or the 'lodash/get' require should be removed from printBuildError.js.
The text was updated successfully, but these errors were encountered: