Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In DevServer mode request for /favicon.ico is proxied to the back-end #2324

Closed
mihhail-lapushkin opened this issue May 22, 2017 · 5 comments · Fixed by #2326
Closed

In DevServer mode request for /favicon.ico is proxied to the back-end #2324

mihhail-lapushkin opened this issue May 22, 2017 · 5 comments · Fixed by #2326
Labels
issue: bug
Milestone
1.0.5

Comments

@mihhail-lapushkin
Copy link

mihhail-lapushkin commented May 22, 2017 •
edited
Loading

Does anyone else have this problem?
This started happening with react-scripts >= 1.0.0
Using Chrome 58.0.3029.110 and react-scripts 1.0.4

In index.html everything is same:

<link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico">
@subk
Copy link

subk commented May 22, 2017

Same for me when I use the proxy property in package.json, which makes sense.
Probably because of react-dev-utils/WebpackDevServerUtils.js#L273 ?

@gaearon
Copy link
Contributor

gaearon commented May 22, 2017

Could be related to changes to proxy handling in #1790.

cc @jamesblight @Timer

@gaearon
Copy link
Contributor

gaearon commented May 22, 2017

I’m confused why logo.svg does not attempt to go through the proxy but favicon.ico does.

@gaearon
Copy link
Contributor

gaearon commented May 22, 2017

I guess there’s a bigger issue here: every file in public folder tries to go through the proxy. This is a critical bug, as it breaks any app relying on public folder.

@gaearon gaearon added this to the 1.0.5 milestone May 22, 2017
@gaearon gaearon mentioned this issue May 22, 2017
Merged
@gaearon
Copy link
Contributor

gaearon commented May 22, 2017

Fixed in [email protected].

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: bug
Projects
None yet
Milestone
1.0.5
Development

Successfully merging a pull request may close this issue.

Files in public/ folder should not be requested through proxy gaearon/create-react-app
3 participants
@gaearon @mihhail-lapushkin @subk