-
Notifications
You must be signed in to change notification settings - Fork 1.2k
arm64-v8a ABI is not supported in NdkCxxPlatform #414
Comments
This should be as simple as adding a new entry in `NdkCxxPlatforms`, if
you happen to feel mildly ambitious.
|
More specifically here:
|
4abf4af is an example of how to add another platform as well. |
@LegNeato were you planning on PR'ing LegNeato@9e14600? |
@ajtulloch Not currently. Mainly because it has probably bitrotted and I don't have a test project to muck around with to make sure everything works correctly. |
This looks fine to me, though the default flags should be updated to match https://android.googlesource.com/platform/ndk.git/+/nougat-release/build/core/toolchains/aarch64-linux-android-4.9/setup.mk . |
@LegNeato , can you PR it just so we can use our normal import/CLA machinery? We can probably get someone else to handle the rebase, cleanup, and test. |
It actually rebased cleanly. I'll PR, do you want me to update the flags? I can't really test anything 😄 |
@LegNeato sure, that would be great. We'll test internally. |
This is for 64-bit ARMv8-a support: https://developer.android.com/ndk/guides/abis.html#arm64-v8a
The text was updated successfully, but these errors were encountered: