Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

arm64-v8a ABI is not supported in NdkCxxPlatform #414

Closed
ide opened this issue Sep 10, 2015 · 9 comments
Closed

arm64-v8a ABI is not supported in NdkCxxPlatform #414

ide opened this issue Sep 10, 2015 · 9 comments

Comments

@ide
Copy link

ide commented Sep 10, 2015

This is for 64-bit ARMv8-a support: https://developer.android.com/ndk/guides/abis.html#arm64-v8a

@sdwilsh
Copy link
Contributor

sdwilsh commented Sep 10, 2015 via email

@LegNeato
Copy link
Contributor

LegNeato commented Oct 1, 2015

More specifically here:

NdkCxxPlatform armeabiv7 =

@sdwilsh
Copy link
Contributor

sdwilsh commented Feb 1, 2016

4abf4af is an example of how to add another platform as well.

@ajtulloch
Copy link

@LegNeato were you planning on PR'ing LegNeato@9e14600?

@LegNeato
Copy link
Contributor

LegNeato commented Oct 5, 2016

@ajtulloch Not currently. Mainly because it has probably bitrotted and I don't have a test project to muck around with to make sure everything works correctly.

@dreiss
Copy link
Member

dreiss commented Oct 5, 2016

This looks fine to me, though the default flags should be updated to match https://android.googlesource.com/platform/ndk.git/+/nougat-release/build/core/toolchains/aarch64-linux-android-4.9/setup.mk .

@dreiss
Copy link
Member

dreiss commented Oct 5, 2016

@LegNeato , can you PR it just so we can use our normal import/CLA machinery? We can probably get someone else to handle the rebase, cleanup, and test.

@LegNeato
Copy link
Contributor

LegNeato commented Oct 5, 2016

It actually rebased cleanly. I'll PR, do you want me to update the flags? I can't really test anything 😄

@ajtulloch
Copy link

@LegNeato sure, that would be great. We'll test internally.

LegNeato added a commit to LegNeato/buck that referenced this issue Oct 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants