Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ChoiceChanges.xml support for cpe_remote_pkg #256

Open
erikng opened this issue Jan 27, 2021 · 2 comments
Open

add ChoiceChanges.xml support for cpe_remote_pkg #256

erikng opened this issue Jan 27, 2021 · 2 comments

Comments

@erikng
Copy link
Contributor

erikng commented Jan 27, 2021

When a Change Needs a Design Proposal

I'd like to propose the following:

  1. new key for cpe_remote_pkg for choicechanges.xml
  2. If you pass this as a boolean it use cpe_remote_file to download the file to the same path as the pkg
  3. passes the argument to for use to installer
  4. it would follow the same naming convention. so something like app_name-choicechanges.xml

Should your team agree, I am happy to write the pull request myself. @nmcspadden has mentioned that cpe_remote_pkg might have reduced usage within Facebook, so I'm not sure if it would be valuable to you all, but it would likely be valuable to other companies.

Why We Use This Process

The current process we use is not ideal.

Motivation

Some packages need a ChoiceChanges.xml file to further customize the installation. This is built-in functionality in munki, however this cannot be worked into the current version of cpe_remote_pkg. I have worked around this by utilizing cpe_remote_file and a standard execute block.

Specification

Downstream Impact

I will ensure this is not a breaking change or even required functionality.

@mikedodge04
Copy link
Contributor

Sounds good to me 👍

@erikng
Copy link
Contributor Author

erikng commented Jan 28, 2021

@mikedodge04 sweet. For context this is what I currently have to do to get what I want: uber/client-platform-engineering#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants