Add autoprefixing to CSS pipeline #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add [autoprefixer](https://github.com/postcss/autoprefixer) as a final build step in the CSS pipeline.
|
Deploy preview for docusaurus-preview ready! Built with commit 8a4fcf8 |
endiliey
reviewed
Jul 21, 2018
| function autoPrefixCss(cssContent) { | ||
| return postcss([autoprefixer]) | ||
| .process(cssContent, { | ||
| from: undefined, |
There was a problem hiding this comment.
is this from: undefined, required ?
There was a problem hiding this comment.
Yes. The from option is for defining the source file for source maps, but the current implementation rewrites the source file, so a source map is not possible.
Without the from: undefined, an error is logged to the console asking to include the from: undefined option.
yangshun
approved these changes
Jul 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autoprefixer as a final build step in the CSS pipeline.
Motivation
Fix #784
Suggestion from #784 to add autoprefixing to the CSS pipeline.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
autoprefix cssunit test inutils.test.js, modeled after theminify csstest.test.cssto include css rule that triggers autoprefixer. Updated snapshots of theminify csstest to include the new css rule.Related PRs
None.