You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found this issue originally in the jest website. And after some discussion we figured that it would be ideal to fix this issue in the upstream.
If you look at the website of docusaurus, when the text is on the right side, the blockImage has a right margin in between, which is a margin-right:
However, when the text is on the left side, the blockImage doesn't fit this margin to a margin-left, which leaves no space in between the image and block text:
And in the jest website, it looks ugly when the boundary is obvious to note this issue:
I think it would be ideal to add a parameter to the component to specify where should be the margin added, like left or right.
I'd love to fix this issue and submit a PR if it is recognized. 😄
The text was updated successfully, but these errors were encountered:
Is this a bug report?
bug
(write your answer here)
Have you read the Contributing Guidelines?
(Write your answer here.)
Yes
Expected Behavior
I found this issue originally in the
jest
website. And after some discussion we figured that it would be ideal to fix this issue in the upstream.If you look at the website of docusaurus, when the text is on the right side, the
blockImage
has a rightmargin
in between, which is amargin-right
:However, when the text is on the left side, the
blockImage
doesn't fit this margin to amargin-left
, which leaves no space in between the image and block text:And in the
jest
website, it looks ugly when the boundary is obvious to note this issue:I think it would be ideal to add a parameter to the component to specify where should be the
margin
added, likeleft
orright
.I'd love to fix this issue and submit a PR if it is recognized. 😄
The text was updated successfully, but these errors were encountered: