Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The imgAlignSide component only has a margin-right #397

Closed
cyan33 opened this issue Jan 13, 2018 · 1 comment · Fixed by #398
Closed

The imgAlignSide component only has a margin-right #397

cyan33 opened this issue Jan 13, 2018 · 1 comment · Fixed by #398

Comments

@cyan33
Copy link

cyan33 commented Jan 13, 2018

Is this a bug report?

bug

(write your answer here)

Have you read the Contributing Guidelines?

(Write your answer here.)
Yes

Expected Behavior

I found this issue originally in the jest website. And after some discussion we figured that it would be ideal to fix this issue in the upstream.

If you look at the website of docusaurus, when the text is on the right side, the blockImage has a right margin in between, which is a margin-right:

image

However, when the text is on the left side, the blockImage doesn't fit this margin to a margin-left, which leaves no space in between the image and block text:

image

And in the jest website, it looks ugly when the boundary is obvious to note this issue:

image

I think it would be ideal to add a parameter to the component to specify where should be the margin added, like left or right.

I'd love to fix this issue and submit a PR if it is recognized. 😄

@JoelMarcey
Copy link
Contributor

@cyan33 Sorry I didn't respond to this sooner. I would, of course, have loved a PR. I appreciate any PRs to fix bugs :)

We will go with #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants