Enable setting of title for custom pages

* allowing custom title on page component * Update about-slash.js * Update help.js * Update users.js * Update versions.js
facebook · May 31, 2018 · 72f4f36 · 72f4f36
1 parent b3d59f8
commit 72f4f36
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 2 deletions.
diff --git a/lib/server/generate.js b/lib/server/generate.js
@@ -498,6 +498,7 @@ async function execute() {
             <Site
               language={language}
               config={siteConfig}
+              title={ReactComp.title}
               metadata={{id: pageID}}>
               <ReactComp language={language} />
             </Site>
@@ -513,7 +514,11 @@ async function execute() {
         let language = env.translation.enabled ? 'en' : '';
         translate.setLanguage(language);
         const str = renderToStaticMarkupWithDoctype(
-          <Site language={language} config={siteConfig} metadata={{id: pageID}}>
+          <Site
+            title={ReactComp.title}
+            language={language}
+            config={siteConfig}
+            metadata={{id: pageID}}>
             <ReactComp language={language} />
           </Site>
         );
@@ -526,7 +531,11 @@ async function execute() {
         let language = env.translation.enabled ? 'en' : '';
         translate.setLanguage(language);
         const str = renderToStaticMarkupWithDoctype(
-          <Site language={language} config={siteConfig} metadata={{id: pageID}}>
+          <Site
+            title={ReactComp.title}
+            language={language}
+            config={siteConfig}
+            metadata={{id: pageID}}>
             <ReactComp language={language} />
           </Site>
         );

diff --git a/lib/server/server.js b/lib/server/server.js
@@ -442,6 +442,7 @@ function execute(port) {
         <Site
           language={language}
           config={siteConfig}
+          title={ReactComp.title}
           metadata={{id: path.basename(userFile, '.js')}}>
           <ReactComp language={language} />
         </Site>

diff --git a/website/pages/en/about-slash.js b/website/pages/en/about-slash.js
@@ -40,4 +40,6 @@ AboutSlash.defaultProps = {
   language: "en"
 };
 
+AboutSlash.title = 'About Slash';
+
 module.exports = AboutSlash;
diff --git a/website/pages/en/help.js b/website/pages/en/help.js
@@ -61,4 +61,6 @@ class Help extends React.Component {
   }
 }
 
+Help.title = 'Help';
+
 module.exports = Help;
diff --git a/website/pages/en/users.js b/website/pages/en/users.js
@@ -80,4 +80,6 @@ class Users extends React.Component {
   }
 }
 
+Users.title = 'Users';
+
 module.exports = Users;
diff --git a/website/pages/en/versions.js b/website/pages/en/versions.js
@@ -102,4 +102,6 @@ class Versions extends React.Component {
   }
 }
 
+Versions.title = 'Versions';
+
 module.exports = Versions;
-Original file line number
+Diff line change
@@ Expand Up / @@ -61,4 +61,6 @@ class Help extends React.Component { @@
       }
     }
+    Help.title = 'Help';
     module.exports = Help;