Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure TestCase.setUp is executed in tests #2384

Closed
wants to merge 1 commit into from
Closed

Make sure TestCase.setUp is executed in tests #2384

wants to merge 1 commit into from

Commits on Apr 19, 2024

  1. Make sure TestCase.setUp is executed in tests 

    Summary: The logger & warning filters in `TestCase.setUp` are only effective if it gets executed. Many test definitions were overwriting `setUp` without a `super().setUp()` call, ignoring these filters.

Reviewed By: esantorella

Differential Revision: D56375193
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3a1d95d View commit details
    Browse the repository at this point in the history