Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Path stroke bbox #8399

Open
7 tasks done
vitonsky opened this issue Oct 28, 2022 · 8 comments
Open
7 tasks done

[Bug]: Path stroke bbox #8399

vitonsky opened this issue Oct 28, 2022 · 8 comments
Assignees
Labels

Comments

@vitonsky
Copy link
Contributor

vitonsky commented Oct 28, 2022

CheckList

  • I agree to follow this project's Code of Conduct
  • I have read and followed the Contributing Guide
  • I have read and followed the Issue Tracker Guide
  • I have searched and referenced existing issues and discussions
  • I am filing a BUG report.
  • I have managed to reproduce the bug after upgrading to the latest version
  • I have created an accurate and minimal reproduction

Version

5.2.1

In What environments are you experiencing the problem?

Chrome

Node Version (if applicable)

No response

Link To Reproduction

https://codesandbox.io/s/delicate-surf-2uq4wr

Steps To Reproduce

  1. Open https://codesandbox.io/s/delicate-surf-2uq4wr or https://2uq4wr.csb.app/
  2. Try to change zoom and toggle objectCaching

Expected Behavior

Figure must be circle. Any zoom changes must not affect on shape of figure

Actual Behavior

You see a critically distorted figure, it's not a circle.

If you set zoom = 1 or will disable cache, you will see a correct shape.

Error Message & Stack Trace

No response

@vitonsky vitonsky changed the title [Bug]: A critical distorting of path after zoom canvas [Bug]: Critical distorting a path after zoom canvas Oct 28, 2022
@vitonsky
Copy link
Contributor Author

Screenshot

@ShaMan123
Copy link
Contributor

I think fabric isn't fully there in term of the arc command.
But I am guessing.
Using Circle as a workaround answers your needs?

@vitonsky
Copy link
Contributor Author

@ShaMan123 no, it works that not only for circle, but for all shapes with rounded border, for example for rhombus

@ShaMan123
Copy link
Contributor

Are you talking about stroke bounding box? #8344 ? #8040 ?

@vitonsky
Copy link
Contributor Author

@ShaMan123 yes, it looks like. Is your PR will fix this problem?

@ShaMan123
Copy link
Contributor

Should
Polyline/Polygon are fixed
Path still needs looking into
Contributions are welcome

@vitonsky
Copy link
Contributor Author

Why this problem occur only when cache enabled?

@ShaMan123
Copy link
Contributor

It isn't really.
As you can see the bbox is wrong when you select the object.
Since caching depends on bbox calculation you see the severity of the bug there as opposed to the selection box which doesn't affect the object's rendering so you may consider that as less acute.

@ShaMan123 ShaMan123 linked a pull request Oct 30, 2022 that will close this issue
1 task
@ShaMan123 ShaMan123 self-assigned this Oct 30, 2022
@ShaMan123 ShaMan123 changed the title [Bug]: Critical distorting a path after zoom canvas [Bug]: Path stroke bbox Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants