Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group selector uses canvas coordinates which can correspond to different fabric coordinate when panning/zooming while selecting #7086

Closed
SLKnutson opened this issue May 27, 2021 · 1 comment
Labels
stale Issue marked as stale by the stale bot

Comments

@SLKnutson
Copy link
Contributor

Version

4.5.0, don't think this has changed recently

Test Case

http://fabricjs.com/fabric-intro-part-5

Information about environment

Any browser

Steps to reproduce

  1. Go to the first fabric canvas on http://fabricjs.com/fabric-intro-part-5
  2. Use a mouse with a scroll wheel
  3. Hold down the left mouse button
  4. Move the mouse slightly to create a blue selection area
  5. While keeping the mouse button held down, zoom in or out using the mouse wheel

Expected Behavior

The grouping should stay anchored to the original fabric coordinate that it was created in

Actual Behavior

The grouping is anchored to the canvas offset that it was originally created in

Reasoning

Not super obvious with the zooming in/out, but this is really evident when implementing autopanning when the cursor moves to the edge of the canvas. Theoretically someone could want it to behave the way that it currently does, but I can't imagine why.

Thanks!

@stale
Copy link

stale bot commented Jun 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jun 10, 2021
@stale stale bot closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue marked as stale by the stale bot
Projects
None yet
Development

No branches or pull requests

1 participant