-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text on path incorrect tangent angle #6750
Comments
I must have broke something quick, because in the PR looked good. |
There should be a way to calculate the angle on those curves without using 2 near points, i need to find out. |
i think here is the answer: |
The changes are interesting because they remove one full iteration to find the angle, compared to before. |
Version
4.3.0
Test Case
https://jsfiddle.net/melchiar/1vdjfLc8/
Information about environment
Tested with Chrome, Firefox
Steps to reproduce
The new text on path functionality seems to be calculating tangent angle incorrectly at certain points on a curve (note the angle of the l, i, and n characters)
The text was updated successfully, but these errors were encountered: