Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doubleclick on non-selectable IText fires "text:selection:changed"-Event #5981

Closed
awehring opened this issue Nov 18, 2019 · 1 comment · Fixed by #6011
Closed

Doubleclick on non-selectable IText fires "text:selection:changed"-Event #5981

awehring opened this issue Nov 18, 2019 · 1 comment · Fixed by #6011
Labels
bug
Milestone
3.5.2

Comments

@awehring
Copy link

Description

See Title.

It's a minor issue, but can be confusing in some applications.

Version

3.4.0

Test Case

https://jsfiddle.net/awehring/authmgs1/3/

Information about environment

Edge, Firefox

Steps to reproduce

  • Add an Itext object to canvas
  • Set selectable: false, editable: false
  • Doubleclick the text

Expected Behavior

No selection event will be fired

Actual Behavior

text:selection:changed event is fired
@awehring awehring mentioned this issue Nov 19, 2019
Closed
@asturur asturur added the bug label Nov 20, 2019
@asturur asturur added this to the 3.5.2 milestone Nov 20, 2019
@asturur
Copy link
Member

asturur commented Dec 1, 2019

i think has been fixed in current master

@asturur asturur mentioned this issue Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.5.2
Development

Successfully merging a pull request may close this issue.

ISSUE-5867 Fix the extra new line selection with empty line fabricjs/fabric.js
2 participants
@asturur @awehring