Regression in Drawing => disappearing dots

[niels-van-den-broeck]

Version

3.1.0

Test Case

https://codesandbox.io/s/dots-disappearing-9vll1

Information about environment

Nodejs or browser?
Which browsers?

Chrome@latest
Others not tested

Steps to reproduce

draw dots on attached sandbox

Expected Behavior

dots stay

Actual Behavior

dots go away at random

[asturur]

i inspected the objects, between one disappeared and one not disappeared there are virtually no differences.
I have no idea what is happening.
Your code is fine.

I wonder if is a mutation problem.
we are resetting points doing points.length = 0, i wonder if is better to assign a new array completely.
And also the decimation and the convert to pathData could happen on a copy of the dots rather than the actual array.

[paulconlin]

Not sure if it's related, but the drawing demo also has an issue the paths moving when committed to the second canvas.

http://fabricjs.com/freedrawing

[Zahin-10]

I have been using a really old version 2.4.1 this issue doesn't seem to happen over here and we have been running it in production for a while now.

[asturur]

I'll change some code to see if i can fix, but i still miss a way to replicate the problem fast. Sometimes i have to add hundreds of dots before seeing one disappear

[asturur]

Found the issue, pushing a fix and publishing.

[niels-van-den-broeck]

Thanks!

[niels-van-den-broeck]

Not sure if it's related, but the drawing demo also has an issue the paths moving when committed to the second canvas.

http://fabricjs.com/freedrawing

I assume the version hasn't been bumped yet on the demo site but this has already been fixed earlier