Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas toSVG ,the svg will break #5436

Closed
xmqywx opened this issue Dec 18, 2018 · 4 comments · Fixed by #5438
Closed

Canvas toSVG ,the svg will break #5436

xmqywx opened this issue Dec 18, 2018 · 4 comments · Fixed by #5438
Labels

Comments

@xmqywx
Copy link

xmqywx commented Dec 18, 2018

Version

2.4.5 bad
2.4.3 and 2.4.4 show well

Test Case

http://fabricjs.com/kitchensink

Information about environment

brower
Which browsers?
chrome 70.0.3538.110

Steps to reproduce

http://fabricjs.com/docs/fabric.Canvas.html#toSVG
canvas toSVG image

Expected Behavior

image
image

@asturur
Copy link
Member

asturur commented Dec 18, 2018

omg that is terrible. How did it pass the tests?

@Rexdelapits
Copy link

Yeah, I had similar problems with the move to 2.4.5. Which is a shame because I really need the fix that stops a second transform being added to my clip paths (which did seem to be working great btw - thanks)

@mediumhust
Copy link

In shapes/path.class.js I've added again specificTransform which removed in #aadfea00faf28b3f8c4d8013dbf781415c3a432a
Now export to SVG working nomarlly.
@asturur Why you must remove "specificTransform "?

@asturur
Copy link
Member

asturur commented Dec 20, 2018

Because specific transform is added in COMMON_PARTS already.
But eventually something went wrong. That was a clipPath bug and i checked just clipPath when i modified it. I have a full test page that is all broken, that i did not look at.
Human error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants