Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two finger gestures broken after 2.3.0 #5167

Closed
pawel-pawlowski opened this issue Aug 14, 2018 · 2 comments · Fixed by #5177
Closed

Two finger gestures broken after 2.3.0 #5167

pawel-pawlowski opened this issue Aug 14, 2018 · 2 comments · Fixed by #5177

Comments

@pawel-pawlowski
Copy link

Version

2.3.0

Steps to reproduce

  1. Add image to canvas with gestures support enabled
  2. Zoom or rotate with two fingers

Expected Behavior

Image is scaled and/or rotated.

Actual Behavior

Image is zoomed only at the end of the gesture. Rotation is not applied. The following error appears in the console:
bug

@sameermanuja
Copy link

_fire now expects the event name and an options object. _scaleObjectBy and _rotateObjectByAngle are still using the old form.

Defining an options object:
var options = {
e: e,
target: t.target,
transform: t
};
and calling _fire with options fixes this.

@asturur
Copy link
Member

asturur commented Aug 19, 2018

you may have found the problem.
I refactored some events and completely forgot about the 2 fingers gestures.

The truth is that they are half unsupported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants