Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boundsOfCurveCache grows unbounded #5137

Closed
sherburne opened this issue Aug 2, 2018 · 0 comments · Fixed by #5140
Closed

boundsOfCurveCache grows unbounded #5137

sherburne opened this issue Aug 2, 2018 · 0 comments · Fixed by #5140

Comments

@sherburne
Copy link

Hello... I've got a use-case where I'm using Fabric's freehand drawing mode to collect handwritten annotations in a mobile app for iOS/Android/Windows 10. The app uses Fabric 2.3.2 with Ionic 3.9.2 and Cordova 7. A user may make thousands of notes while using the app, and I've noticed that boundsOfCurveCache (in fabric.util.getBoundsOfCurve) will grow to occupy a considerable amount of memory over time. Currently the only way this cache is cleared is when the app restarts or the webview is reloaded.

I'd like a way to either disable the cache or manually clear it. I'm more than happy to submit a PR with my suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove caching of some path parsing steps fabricjs/fabric.js
1 participant
@sherburne