Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric js on Google Chrome #4867

Closed
jmd60 opened this issue Mar 29, 2018 · 9 comments · Fixed by #4933
Closed

Fabric js on Google Chrome #4867

jmd60 opened this issue Mar 29, 2018 · 9 comments · Fixed by #4933
Labels

Comments

@jmd60
Copy link

jmd60 commented Mar 29, 2018

Hi,
I use fabric js on Chrome 65 and touch event doesn't work.
The version of fabric.js is 1.7.9, I tested fabric.js 2.2.2 and the result is the same.

I tested the example : http://fabricjs.com/touch-events and I have this message in the console
fabric_with_gestures.js:11314 [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080

Is there any implementations i need to do? Thank you for your time and efforts.

Jean-Michel

@asturur
Copy link
Member

asturur commented Mar 31, 2018

i think this is a bug.
I think that we switched all the events as passive and this is bad.

@asturur asturur added the bug label Mar 31, 2018
@tjaska
Copy link

tjaska commented Apr 21, 2018

I have the same bug. Is there a workaround for that? This seems to be a deal-breaker when using fabric in kiosk solutions.

@asturur
Copy link
Member

asturur commented Apr 21, 2018

should be easy fixable

@slahser1992
Copy link

hello, fixed it already? @asturur

@asturur
Copy link
Member

asturur commented Apr 24, 2018

no! did not have time

@slahser1992
Copy link

I will be try today. should be easy.

@slahser1992
Copy link

could you give me some suggestions for fixing this bug please. I found set passive to false in fabric at line 5468. it will not give me a warn. @asturur

@asturur
Copy link
Member

asturur commented Apr 27, 2018

Pushing up one update that let me drag in chrome mobile simulator with fabric 2.2.3
Can you try it now on fabricjs.com?

@asturur
Copy link
Member

asturur commented Apr 27, 2018

(refresh a couple of time to be sure to get the new build)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants