Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous lines #4545

Closed
laof opened this issue Dec 8, 2017 · 11 comments · Fixed by #4549
Closed

Superfluous lines #4545

laof opened this issue Dec 8, 2017 · 11 comments · Fixed by #4549

Comments

@laof
Copy link
Contributor

laof commented Dec 8, 2017

Version

  • fabric.js version: 2.0.0-rc.3
  • Chrome version:61.0.3163.79

Test Case

http://fabricjs.com/

Steps to reproduce

Ask one thing, when the object is rotated, there are two lines appearing. As shown in the picture,
How to solve it, help ,thank you!

Expected Behavior

line

gw

Actual Behavior

@asturur
Copy link
Member

asturur commented Dec 9, 2017

I do not see those lines.
Do you see on other browsers or simply other computer too?

what OS are you on?

@JSteunou
Copy link
Contributor

JSteunou commented Dec 9, 2017

never seen those glitch too, but I know that sometimes weird things can happen with Windows and bad graphic drivers.

@asturur
Copy link
Member

asturur commented Dec 9, 2017

Also please replicate turning off the hw accell from chrome, if they disappear is a driver issue

@laof
Copy link
Contributor Author

laof commented Dec 9, 2017

I'm sorry, I forgot to say, I'm using Windows 7. There's the same problem on desktop and laptop computers. I can make sure that the phone is normal

@asturur
Copy link
Member

asturur commented Dec 9, 2017

please try with hw acceleration turned off

@laof
Copy link
Contributor Author

laof commented Dec 9, 2017

OK, I will give it a try

@laof
Copy link
Contributor Author

laof commented Dec 10, 2017

Version

2.0.0-rc.3

Test Case

http://fabricjs.com/

describe

I tested it with two computers and got some data. It's easy to find it related to hardware acceleration. It's not a good way to configure the switch. What should we do now? Thanks

Actual Behavior

Browser  Hw acceleration Finally OS
Chrome 55.0.2883.87 OFF Windows 7
ON ×
Chrome 61.0.3163.79 OFF
ON ×
Firefox 48.0.2 OFF/ON
Firefox Quantum 57.0.2 
Chrome 63.0.3239.84 OFF
ON ×
OFF/ON OS X Yosemite 10.10

@laof
Copy link
Contributor Author

laof commented Dec 10, 2017

Find out the problem, look at the merge request

@asturur
Copy link
Member

asturur commented Dec 10, 2017

so that closePath is effectively extra. and can be removed being a straight line.
outo f curiosity what hardware you tested? what videocard?

@laof
Copy link
Contributor Author

laof commented Dec 10, 2017

The mistake I found in the project. The third point of the triangle is the central coordinates of the canvas, not random . videocard is Intel (R) HD Graphics

@asturur
Copy link
Member

asturur commented Dec 10, 2017

there is no real mistake. happy to have removed that useless line if it helps.

The point is that if do

beginPath, moveTo(p1), lineTo(p2) i do not need to closePath at all, but if i do the closing is in p1 again, the first point i moved to.

Intel HD graphics has some other bugs around, definitely a driver issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants