Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows are clipped within the objects container - see screenshot #3805

Closed
jonofarrow opened this issue Mar 25, 2017 · 9 comments · Fixed by #3864
Closed

Shadows are clipped within the objects container - see screenshot #3805

jonofarrow opened this issue Mar 25, 2017 · 9 comments · Fixed by #3864
Labels

Comments

@jonofarrow
Copy link

I just updated to 1.7.9 (custom build) and noticed that when I apply shadow the shadow is clipped inside of the objects bounding rect. please help! my apps depend on this.

screen shot 2017-03-25 at 4 05 41 pm

@jonofarrow
Copy link
Author

I just need a version with working shadows, gesture support, and the calcTransformMatrix function. Please help!

@jonofarrow
Copy link
Author

fixed this issues with objectCaching = false;
not sure if this is the correct way though.

@asturur
Copy link
Member

asturur commented Mar 26, 2017

shouldn't.

how does it look like the shape without shadow? can you paste the path here?

@jonofarrow
Copy link
Author

The shape looks fine without shadow. Its an svg inside of a pathgroup.
"m 337.73381,606.24658 c 0,0 -26.1194,18.20213 -26.1194,40.45033 0,13.71457 12.08239,19.47772 15.16172,29.96447 4.67449,16.26511 -13.77343,21.31878 -21.51213,12.27265 -5.28932,-6.55521 -9.51528,-31.81849 -9.51528,-31.81849 0,0 -10.89316,15.27077 -11.75315,27.97313 -0.86,12.70237 2.14767,24.22297 9.77359,32.75836 7.62592,8.5354 22.00005,14.77452 36.89203,11.52303 14.89198,-3.25145 32.15841,-13.96628 33.19197,-40.14277 0,-24.92451 -29.39479,-43.85285 -31.66691,-60.79056 -2.27208,-16.9377 5.54756,-22.19015 5.54756,-22.19015 z"

@asturur
Copy link
Member

asturur commented Mar 27, 2017

i need to see your fabric code

@blobinabottle
Copy link
Contributor

I have a bug similar. Shadows behave weird if applied to a group and if you group select 2 or more objects. You can see it here:
http://jsfiddle.net/7gvJG/169/

screen shot 2017-03-30 at 10 42 10

@asturur
Copy link
Member

asturur commented Mar 30, 2017

this last one is a bug.

@blobinabottle
Copy link
Contributor

Do you want me to create a new github issue just for that bug? Or is it already ongoing? Don't hesitate to ask, if I can help you.

@asturur asturur added the bug label Apr 14, 2017
@asturur
Copy link
Member

asturur commented Apr 14, 2017

i need to update the caching logic. if a group has a child with shadow with offsets different from 0, the group cannot be cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants