Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exitEditing from text should clear the caret #3666

Closed
MatBdry opened this issue Feb 2, 2017 · 3 comments · Fixed by #3689
Closed

exitEditing from text should clear the caret #3666

MatBdry opened this issue Feb 2, 2017 · 3 comments · Fixed by #3689

Comments

@MatBdry
Copy link

MatBdry commented Feb 2, 2017

Version

1.7.3

Test Case

https://jsfiddle.net/noeytn5x/7/

Steps to reproduce

Double click on the text box to show the caret. Then, click on the "deactivate all" Button

Expected Behavior

the caret must disappear.

Actual Behavior

the caret is still present

@MatBdry MatBdry changed the title Caret does not disappear on call deactivateAll on canvas. Caret does not disappear on call deactivateAll on canvas Feb 2, 2017
@asturur
Copy link
Member

asturur commented Feb 2, 2017

i see the upper part does not get cleared.
Well deactivateAll should just deactivate. i will change the title in exitEditing from text should clear the caret

@asturur asturur changed the title Caret does not disappear on call deactivateAll on canvas exitEditing from text should clear the caret Feb 2, 2017
@asturur
Copy link
Member

asturur commented Feb 2, 2017

while i search if we need a proper fix, you can still call

canvas.getActiveObject().exitEditing(); before calling deactivateAll, of course you have to check that the activeObject isEditing before.

@MatBdry
Copy link
Author

MatBdry commented Feb 2, 2017

ok, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants