Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

width value for group include the padding value #3427

Closed
ncou opened this issue Nov 17, 2016 · 2 comments
Closed

width value for group include the padding value #3427

ncou opened this issue Nov 17, 2016 · 2 comments

Comments

@ncou
Copy link
Collaborator

ncou commented Nov 17, 2016

Hi,

The width returned for a group take into the value the padding parameter.

Steps :

Use this fiddle and set the padding to "5", select an OBJECT. The width returned in the console is 150px.
Increase the padding value, and redo the test, the width is still 150px.

Try the same test but select a GROUP. the width returned will change depending of the padding value defined in the parameter (460px is returned when the padding is 5px, and 550px is returned when you set the padding at 50px).

http://jsfiddle.net/yvo89upg/1/

I suppose the padding shouldn't influence the group width value (to have the same behaviour as the Object class).

@asturur
Copy link
Member

asturur commented Nov 19, 2016

with good timing this time, this PR, merged one or 2 day before your issue solves the problem
#3420

Dist are not built yet in the repo, you have to build for yourself or wait 1.7.0 release.

@asturur asturur closed this as completed Nov 19, 2016
@ncou
Copy link
Collaborator Author

ncou commented Nov 21, 2016

Hi,

Thank you for the 1.7.0 release, now the padding is no more added to the width value of the object.

While testing, I found something strange when the objects have a scale value.

If i scale up, an image and a rect object, if i made a selection with both objects, the blue control have more space than the image object.
It seems to me there is by default 1px beetween the blue frame and the object, but in the case of "rect object" the space beetween the object and the frame seems to be also scaledUp.

Not really sure to explain correctly myself, here is a screenshot (i put in red the diff), you can see the gap beetween the blue frame and the rect object, but not in the case of the image object.

image

Here is the fiddle. Select both object to reproduce.

Is this normal or possibly a bug ? should i open a new ticket ?

Thank you for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants