-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize canvas with filtered images to SVG broken #3298
Comments
i close this issue as duplicate of: |
This is NOT the same problem (dated 2 years ago). This bug is a regression in 1.6.4 for something that worked just fine before that. The SVG used to be "very big" but that wasn't an issue, for us at least. The main thing was it was working. We don't need additional information about the filters applied (like the person in #1577 wanted), we need the image with applied filters in it, sent as data. |
yes i realized i was wrong. i think somehow i m pulling src from originalelement and not from element. probably when i "fixed" getSrc function. |
give a look at PR should solve the issue. writing tests and merging today. |
Yes, it solves the issue. Thank you! |
Version
1.6.4
Test Case
http://jsfiddle.net/Da7SP/188/
Steps to reproduce
Run the fiddle and open the console. You will see the output of the toSVG canvas function.
In the test case there is one image loaded from URL with filter applied. Then toSVG method is called and logged in the console.
Expected Behavior
When there are images with filters applied, toSVG canvas function should serialize their source and output it in xlink:href attribute as data (base64).
Actual Behavior
With latest release the xlink:href attribute is set to their initial URL.
The text was updated successfully, but these errors were encountered: