You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Draw some iText with no fill and no stroke properties, put fill and stroke in the style instead
Expected Behavior
Text should render
Actual Behavior
Text does not render
This happen because we have a check on stroke and fill before going trought rendering.
There is a ambiguous property in Itext "_skipFillStrokeCheck" that is default to false.
Instead of setting it to true to force rendering of this kind of text, it would be better to add a proper check before rendering:
if ((!this.stroke || this.strokeWidth === 0) && this.isEmptyStyles()) {
return;
}
if ((!this.fill) && this.isEmptyStyles()) {
return;
}
and remove _skipFillStrokeCheck that is of no clear use to me.
Normal text class has no isEmptyStyles functions.
We could do in two way:
check for a lazy !this.styles instead of isEmptyStyles()
add a isEmptyStyles function that return true for the Text class
@kangax and @Kienz if you have 2 minutes i need your opinion on this.
The text was updated successfully, but these errors were encountered:
Version
1.6.0
Test Case
http://jsfiddle.net/Da7SP/39/
Steps to reproduce
Draw some iText with no fill and no stroke properties, put fill and stroke in the style instead
Expected Behavior
Text should render
Actual Behavior
Text does not render
This happen because we have a check on stroke and fill before going trought rendering.
There is a ambiguous property in Itext "_skipFillStrokeCheck" that is default to false.
Instead of setting it to true to force rendering of this kind of text, it would be better to add a proper check before rendering:
and remove _skipFillStrokeCheck that is of no clear use to me.
Normal text class has no isEmptyStyles functions.
We could do in two way:
@kangax and @Kienz if you have 2 minutes i need your opinion on this.
The text was updated successfully, but these errors were encountered: