Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect positioning of rotate control (MTR) on negative height values #10131

Closed
7 tasks done
SupremeDeity opened this issue Sep 6, 2024 · 4 comments
Closed
7 tasks done

Comments

@SupremeDeity
Copy link

CheckList

  • I agree to follow this project's Code of Conduct
  • I have read and followed the Contributing Guide
  • I have read and followed the Issue Tracker Guide
  • I have searched and referenced existing issues and discussions
  • I am filing a BUG report.
  • I have managed to reproduce the bug after upgrading to the latest version
  • I have created an accurate and minimal reproduction

Version

6.0.2

In What environments are you experiencing the problem?

Firefox, Chrome

Node Version (if applicable)

None

Link To Reproduction

https://jsfiddle.net/7kf659vs/10/

Steps To Reproduce

  1. Set height to negative
  2. The mtr icon is inside the bounding

Expected Behavior

The MTR icon should be outside the bounding box

Actual Behavior

image

Error Message & Stack Trace

No response

@SupremeDeity SupremeDeity changed the title [Bug]: [Bug]: Incorrect positioning of rotate control (MTR) on negative height values Sep 6, 2024
@asturur
Copy link
Member

asturur commented Sep 6, 2024

Maybe this bug can be fixed, but there may be others.
Width and height are supposed to be positive numbers.
I can update the documentation

@SupremeDeity
Copy link
Author

@asturur yes ik they are supposed to be positive numbers, i just found out that it works as a easy way to keep the left, top fixed when doing shape drawing.

@asturur
Copy link
Member

asturur commented Sep 7, 2024

#8430
Check if in this PR there is something that helps you having a more integrated draw shape without too much workaronds.
negative width and negative height shouldn't be there.

I understand that when you draw from right to left or from bottom to top you have an issue.
The general logic is to keep track of which direction you moved and keep the position steady with set position by origin.

Maybe we can rework that PR and merge it at some point now that we have the extension bundle

@SupremeDeity
Copy link
Author

@asturur oh that looks nice. Maybe I'll go take a look at that. Currently with the zoom method from the fabric tutorials site, my text and shapes get a bit blurry even with canvas reference and retinaScaling. Maybe I'll find a solution to both this width and height problem and that blur problem in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants