controlsAboveOverlay: true not respected when using canvas.loadFromJSON

[jaydenseric]

controlsAboveOverlay: true canvas option is not respected when using canvas.loadFromJSON. Using console.log on the JSON I can see that the option has been correctly preserved, it is just not being used when being loaded for some reason.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Kienz]

For me it works. Can you create small jsfiddle test case.
Thanks!

[jaydenseric]

Been bug testing furiously for our project's delivery and have come back to this issue. It looks like the same thing is happening to selection: false. We updated Fabric to the latest build from one a week or so ago and the issue persists.

My coworker is taking over this one so I will try to report back or get him in here. A test fiddle would be a 2 fabric canvases, a top one with the settings controlsAboveOverlay: true and selection: false applied, and a bottom one loading the JSON dump of the top.

[Kienz]

@jaydenseric Sorry for my late response - now I can reproduce the error, too.
I've created small jsfiddle testcase: http://jsfiddle.net/Kienz/EGYFX/

[jaydenseric]

Great, I have forgotten all the details and our workaround, but best of luck on a fix :)

[asturur]

The point is that in loadFrom json we do not restore anything but objects, overlay and background. There is nothing restoring "propertiesToInclude"

to fix: We clone the json object, we delete objects and the overlays/background, and the we setOptions(clonedJson);

it should works