Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Openshift Client return 403 when use websocket #4983

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
### 6.6-SNAPSHOT

#### Bugs

* Fix #4963: Openshift Client return 403 when use websocket
#### Improvements

#### Dependency Upgrade
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import io.fabric8.kubernetes.client.http.BasicBuilder;
import io.fabric8.kubernetes.client.http.HttpClient;
import io.fabric8.kubernetes.client.http.HttpRequest;
import io.fabric8.kubernetes.client.http.HttpRequest.Builder;
import io.fabric8.kubernetes.client.http.HttpResponse;
import io.fabric8.kubernetes.client.http.Interceptor;
import io.fabric8.kubernetes.client.utils.HttpClientUtils;
Expand Down Expand Up @@ -93,7 +92,7 @@ public void before(BasicBuilder builder, HttpRequest httpRequest, RequestTags ta
}

@Override
public CompletableFuture<Boolean> afterFailure(Builder builder, HttpResponse<?> response, RequestTags tags) {
public CompletableFuture<Boolean> afterFailure(BasicBuilder builder, HttpResponse<?> response, RequestTags tags) {
if (shouldProceed(response.request(), response)) {
return CompletableFuture.completedFuture(false);
}
Expand Down Expand Up @@ -121,7 +120,7 @@ public CompletableFuture<Boolean> afterFailure(Builder builder, HttpResponse<?>
return CompletableFuture.completedFuture(refreshFromConfig(builder));
}

private boolean refreshFromConfig(Builder builder) {
private boolean refreshFromConfig(BasicBuilder builder) {
Config newestConfig = config.refresh(); // does some i/o work, but for now we'll consider this non-blocking
String oauthToken = newestConfig.getOauthToken();
if (oauthToken != null) {
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading