Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2163: kubernetes client support cert chain #2164

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix #2163: kubernetes client support cert chain #2164

merged 1 commit into from
Apr 27, 2020

Conversation

phantooom
Copy link

@phantooom phantooom commented Apr 26, 2020 •
edited by manusa
Loading

Fixes: #2163

@centos-ci
Copy link

Can one of the admins verify this patch?

@phantooom phantooom changed the title FIX #2163: kubernetes client support cert chain Fix #2163: kubernetes client support cert chain Apr 27, 2020
@phantooom phantooom mentioned this pull request Apr 27, 2020
Closed
@rohanKanojia
Copy link
Member

ok to test

@rohanKanojia rohanKanojia requested review from oscerd and manusa April 27, 2020 04:51
@manusa manusa added the changelog missing A line to changelog.md regarding the change is not added label Apr 27, 2020
manusa
manusa approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thnx!! Please include a line in CHANGELOG.md indicating this fixes bug reported in #2163

@phantooom
Copy link
Author

changelog added.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rohanKanojia
Copy link
Member

[merge]

@fusesource-ci fusesource-ci merged commit a97aeb9 into fabric8io:master Apr 27, 2020
@phantooom phantooom deleted the rui.zou/fix-auth branch April 27, 2020 11:01
@manusa manusa mentioned this pull request Apr 28, 2020
Closed
@manusa manusa removed the changelog missing A line to changelog.md regarding the change is not added label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubernetes client not support cert chain
7 participants
@phantooom @centos-ci @rohanKanojia @manusa @oscerd @fusesource-ci @fabric8cd