Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.getFile can be inferred from Config.currentContext #6554

Closed
manusa opened this issue Nov 7, 2024 · 0 comments · Fixed by #6555
Closed

Config.getFile can be inferred from Config.currentContext #6554

manusa opened this issue Nov 7, 2024 · 0 comments · Fixed by #6555
Assignees
Milestone

Comments

@manusa
Copy link
Member

manusa commented Nov 7, 2024

Description

Part of #6516

The field Config.file is used internally for refreshing the Config (Config.refresh) and persisting updated token values (OpenIDConnectionUtils.persistOAuthToken).

In addition, the field is exposed via Config.getFile, which is used downstream to evaluate if the Config was inferred from a file.
In #6240 this feature should be improved to include an additional Config.getFiles to retrieve the kubeconfig files that were evaluated when inferring the Config.

After the improvements in #6250 and others, the field is no longer needed, since this information is persisted in the NamedContext instances available at Config.currentContext and Config.contexts.

The values available here should be used instead and the fields and constructor/builder parameters should be removed.

@manusa manusa moved this to In Progress in Eclipse JKube Nov 7, 2024
@manusa manusa self-assigned this Nov 7, 2024
@manusa manusa added this to the 7.0.0 milestone Nov 7, 2024 — with automated-tasks
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant