Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultMockServerWebSocketTest failing intermittently on CI #6228

Closed
rohanKanojia opened this issue Aug 7, 2024 · 1 comment · Fixed by #6310 or #6311
Closed

DefaultMockServerWebSocketTest failing intermittently on CI #6228

rohanKanojia opened this issue Aug 7, 2024 · 1 comment · Fixed by #6310 or #6311
Assignees
Labels
component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly test
Milestone

Comments

@rohanKanojia
Copy link
Member

Is your task related to a problem? Please describe

I've seen repeated failures of DefaultMockServerWebSocketTest on GitHub actions CI , for example this one

Error:  Failures: 
Error:    DefaultMockServerWebSocketTest.andUpgradeToWebSocket, with request header 'sec-websocket-protocol', should create response with matching header:203->andUpgradeToWebSocket, with request header 'sec-websocket-protocol', should create response with matching header_closure11:-1->andUpgradeToWebSocket, with request header 'sec-websocket-protocol', should create response with matching header_closure11:204 Condition failed with Exception:

future.get(10, TimeUnit.SECONDS) == "v4.channel.k8s.io"
|      |       |
|      |       class java.util.concurrent.TimeUnit
|      java.util.concurrent.TimeoutException
|      	at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
|      	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
|      	at io.fabric8.mockwebserver.DefaultMockServerWebSocketTest.andUpgradeToWebSocket, with request header 'sec-websocket-protocol', should create response with matching header_closure11(DefaultMockServerWebSocketTest.groovy:204)
|      	at spock.util.concurrent.AsyncConditions.evaluate(AsyncConditions.java:101)
|      	at io.fabric8.mockwebserver.DefaultMockServerWebSocketTest.andUpgradeToWebSocket, with request header 'sec-websocket-protocol', should create response with matching header(DefaultMockServerWebSocketTest.groovy:203)
java.util.concurrent.CompletableFuture@6a486afb[Not completed]

Describe the solution you'd like

DefaultMockServerWebSocketTest should pass uniformly on CI. It shouldn't fail intermittently.

Describe alternatives you've considered

No response

Additional context

No response

@manusa
Copy link
Member

manusa commented Oct 30, 2024

This test doesn't seem to be failing any more since MockWebServer is based on Vert.x.
Closing again.

@manusa manusa closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Eclipse JKube Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly test
Projects
None yet
2 participants