Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesServer mock should set the namespace of a resource being added #3265

Closed
victornoel opened this issue Jun 23, 2021 · 5 comments
Closed

Comments

@victornoel
Copy link

Hi,

When running tests using KubernetesServer, and then with the client doing something like:

var actualJob = client.batch().jobs()
                    .inNamespace(namespace)
                    .create(job);

If job didn't have the namespace set, then actualJob does not have its namespace set, while with an actual k8s API server, I believe it would be set.
I think the same happen if you fetch the jobs from the mock API server.

@shawkins
Copy link
Contributor

Duplicate of #3194

@shawkins shawkins marked this as a duplicate of #3194 Jun 23, 2021
@victornoel
Copy link
Author

@shawkins nice, thx!

@victornoel
Copy link
Author

@shawkins also, any way to get it in 5.4.2 maybe? Or will 5.5 be released soon?

@shawkins
Copy link
Contributor

There's been a lot of changes to the mock server in 5.5, so it's not a quick hit to pull this into 5.4.2. Since it seems like you are already looking for other things that are in 5.5 it would be simplest to just pick up that release.

@victornoel
Copy link
Author

@shawkins yep, totally agree, thx again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants