Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodSpec should be considered Buildable in all extensions #2976

Closed
iocanel opened this issue Apr 9, 2021 · 5 comments
Closed

PodSpec should be considered Buildable in all extensions #2976

iocanel opened this issue Apr 9, 2021 · 5 comments

Comments

@iocanel
Copy link
Member

iocanel commented Apr 9, 2021

The issue is that PodSpec which is part of the core model, is also used in extensions (e.g. knative).
By not considering it Buidlable, visitors are broken causing lots of issues in downstream projects.

A manifestation of the issue: quarkusio/quarkus#16376

So, PodSpec needs to be included.
Ideally, we should be more to be more generic and somehow include all core types.

@iocanel iocanel self-assigned this Apr 9, 2021
@manusa
Copy link
Member

manusa commented Apr 9, 2021

From discussion:

  • Inheritance doesn't seem to be supported by json-schema: How to do inheritance? json-schema-org/json-schema-spec#348

    So, I hope that helped. Schemas are not describing objects, they are a collection of constraints. So, thinking in terms of inheritance doesn't work.

  • Inheritance would be a great advantage for Visitors. e.g. a PodSpec visitor would also apply to all RevisionSpecBuilder(s).

Approaches for the PodSpec/RevisionSpec class with our current setup could be:

  • Manually overriding RevisionSpec (delete generated class), and make it extend PodSpec
  • Investigate the possibility to add some sort of meta-data to the generated json-schema to indicate that an object inherits another and then use our processors to generate the java sources accordingly.

@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jul 8, 2021
@stale stale bot removed the status/stale label Jul 8, 2021
@iocanel iocanel changed the title PodSpec should be considered Buildable in all extensions OPEN PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title OPEN PodSpec should be considered Buildable in all extensions PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title PodSpec should be considered Buildable in all extensions OPEN PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title OPEN PodSpec should be considered Buildable in all extensions PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title PodSpec should be considered Buildable in all extensions OPEN PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title OPEN PodSpec should be considered Buildable in all extensions OPEN OPEN PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title OPEN OPEN PodSpec should be considered Buildable in all extensions OPEN OPEN OPEN PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title OPEN OPEN OPEN PodSpec should be considered Buildable in all extensions OPEN OPEN OPEN OPEN PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel changed the title OPEN OPEN OPEN OPEN PodSpec should be considered Buildable in all extensions PodSpec should be considered Buildable in all extensions Feb 17, 2022
@iocanel iocanel removed their assignment Feb 18, 2022
@iocanel
Copy link
Member Author

iocanel commented Feb 18, 2022

Given the the referenced issue has been worked around I removed my self from the assignee list.

@shawkins
Copy link
Contributor

@iocanel is this related to the changes in sundrio/sundrio#374 and sundrio/sundrio#350 or does there still need to be an explicit declaration that PodSpec is Buildable?

@stale
Copy link

stale bot commented Aug 21, 2023

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Aug 21, 2023
@stale stale bot closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants