Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to configure where the CRD is generated? #2842

Closed
metacosm opened this issue Feb 25, 2021 · 5 comments
Closed

Make it possible to configure where the CRD is generated? #2842

metacosm opened this issue Feb 25, 2021 · 5 comments
Assignees
Milestone

Comments

@metacosm
Copy link
Collaborator

It would make sense to generate all kubernetes-related artifacts in a single location for a given project. As some other projects also generate kubernetes artifacts (dekorate, quarkus), it would make sense for users to be able to select where the CRDs are generated.

Thoughts, @iocanel @manusa?

@manusa
Copy link
Member

manusa commented Mar 2, 2021

I would go for providing a configuration option with a default value.

@metacosm
Copy link
Collaborator Author

metacosm commented Mar 2, 2021

I would go for providing a configuration option with a default value.

Yes, that was my plan as well. I'm just not sure what's the best way to configure it.

@metacosm metacosm self-assigned this Mar 2, 2021
@manusa
Copy link
Member

manusa commented Mar 2, 2021

In relation with #2836 it should be really easy once the CRD-Generator has its own API.

For the APT usage, then probably an annotation or a Maven->System property are the ways to go.

@metacosm
Copy link
Collaborator Author

metacosm commented Mar 9, 2021

Perhaps we could also select a better default location? What do you think, @manusa @iocanel?

@manusa manusa modified the milestones: 5.2.0, 5.3.0 Mar 12, 2021
@metacosm metacosm modified the milestones: 5.4.0, 5.5.0 May 12, 2021
@manusa manusa modified the milestones: 5.5.0, 5.6.0 Jun 29, 2021
@metacosm
Copy link
Collaborator Author

This issue was mostly about the Java Operator SDK work so that CRDs could be generated in the same spot as the files that the Quarkus Kubernetes extension. This was worked around in the Quarkus extension for the Java Operator SDK. While the underlying issue is still valid, there's no more need for this at the moment so closing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants